Nx Cloud Report

CI ran the following commands for commit 713ad3a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@koba04 I like this feature, but I think setting this via an environment variable isn't a scalable way to configure a lot of things... That's what we have main.js for an addons/presets.

In addition I can see the changes you made are in fact quite solid and simple, however, because of work we did on our side, merging this has become really hard. A lot of code moved around, got renamed, and refactored, to support more things (webpack 4 & 5 (and now also vite)), support multiple versions of other packages, and improve performance, to name a few things.

So here's what I propose we do:
If you're still interested in working on this, we should start fresh. Made the changes based on either next or future/base (those 2 branches will meet up soon).

And then we'll want to take the value of the language from a preset.apply call. you can find an example of that here:

It should not be far more complex than what you've currently done.

I hope you're still interested in contributing. I realize we've left this PR completely discarded for way way too long, and I understand how that might have given you the impression that we didn't care.

We do care, your PR is very appreciated. Thank you for your hard work, effort and time.

I can close this PR if you'd indeed like to start fresh. resolving these merge conflict isn't really useful use of your time IMHO.

@ndelangen Thank you!

And then we'll want to take the value of the language from a preset.apply call. you can find an example of that here:

That's definitely a better way than using environment variables!
I'll work on this and create a PR again!